linux-kernel - Re: [PATCH V4] staging: r8188eu: Remove broken rtw_p2p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220503113656.GA4009@kadam>
Date:   Tue, 3 May 2022 14:36:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Charlie Sands <sandsch@...thvilleschools.net>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, paskripkin@...il.com,
        straube.linux@...il.com, fmdefrancesco@...il.com
Subject: Re: [PATCH V4] staging: r8188eu: Remove broken rtw_p2p_get function.

On Sat, Apr 30, 2022 at 12:28:59AM -0400, Charlie Sands wrote:
> Removes broken and unsafe rtw_p2p_get function and all of the code
> associated with it from the r8188eu driver.
> 
> Signed-off-by: Charlie Sands <charlies256@...tonmail.com>
> ---
> 
> Follow up to the patch called "staging: r8188eu: Fix unsafe memory access
> by memcmp." 
> 
> V2: Fixed checkpatch.pl warning and changed variable name as suggested
> by Greg K. H. and improved error checking on the "copy_from_user" function as
> suggested by Pavel Skripkin.
> 
> V3: Return -EFAULT from the function when there is a memory error while
> moving it from user space to kernel space and fix incorrect subject from V2
> 
> V4: Updated commit message and changes to reflect those sugested by Dan 
> Carpenter.
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter