linux-kernel - Re: [PATCH 1/2] serial: 8250: core: Remove unneeded <linux/pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0144ed6-811e-bc2d-7bff-91e7c4ba855@linux.intel.com>
Date:   Tue, 3 May 2022 15:24:23 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Hurley <peter@...leysoftware.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] serial: 8250: core: Remove unneeded
 <linux/pm_runtime.h>

On Mon, 2 May 2022, Geert Uytterhoeven wrote:

> The last calls into Runtime PM were moved to 8250_port.c a long time
> ago.
> 
> Fixes: b6830f6df8914faa ("serial: 8250: Split base port operations from universal driver")

Does this really "fix" something or is it just a useful cleanup? To me it 
looks the latter.

-- 
 i.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/tty/serial/8250/8250_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 01d30f6ed8fb5931..cfbd2de0ca6e4bcd 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -32,7 +32,6 @@
>  #include <linux/mutex.h>
>  #include <linux/slab.h>
>  #include <linux/uaccess.h>
> -#include <linux/pm_runtime.h>
>  #include <linux/io.h>
>  #ifdef CONFIG_SPARC
>  #include <linux/sunserialcore.h>
>