linux-kernel - Re: [PATCH 2/4] dt-bindings: mfd: atmel,flexcom: Add lan966 compatible string and mux properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 May 2022 14:37:38 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>,
        krzysztof.kozlowski+dt@...aro.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        peda@...ntia.se
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, lee.jones@...aro.org,
        linux@...linux.org.uk, Manohar.Puri@...rochip.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH 2/4] dt-bindings: mfd: atmel,flexcom: Add lan966
 compatible string and mux properties

On 03/05/2022 12:55, Kavyasree Kotagiri wrote:
> Add lan966 flexcom compatible string and flexcom mux
> device tree properties
> 
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@...rochip.com>
> ---
>  .../devicetree/bindings/mfd/atmel,flexcom.yaml   | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> index 62dea9b891d8..3e056857c44a 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> @@ -18,6 +18,7 @@ properties:
>    compatible:
>      enum:
>        - atmel,sama5d2-flexcom
> +      - microchip,lan966-flexcom
>  
>    reg:
>      minItems: 1
> @@ -45,6 +46,19 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [0, 1, 2]
>  
> +  # The following optional mux properties are only for lan966 flexcoms

You need allOf:if:then restricting these per compatible.

> +  mux-controls:
> +    minItems: 1

maxItems instead

> +    description: Phandle to the mux controller to map flexcom chip-select
> +     to flexcom shared pin.
> +
> +  mux-control-names:


It looks like mux-consumer, right? You should instead include (in allOf)
the mux-consumer.yaml.

> +    description: String to label the mux controller.
> +    minItems: 1
> +    items:
> +      - const: cs0
> +      - const: cs1
> +
>  required:
>    - compatible
>    - reg
> @@ -64,5 +78,7 @@ examples:
>            #size-cells = <1>;
>            ranges = <0x0 0xf8034000 0x800>;
>            atmel,flexcom-mode = <2>;
> +          mux-controls = <&mux 0>;
> +          mux-control-names = "cs0";
>      };
>  ...


Best regards,
Krzysztof