linux-kernel - RE: [RFC PATCH pdx86-platform-drivers-x86] platform/x86: thinkpad_acpi: quirk_btusb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 May 2022 13:07:13 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     kernel test robot <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC PATCH pdx86-platform-drivers-x86] platform/x86:
 thinkpad_acpi: quirk_btusb_bug can be static

[Public]



> -----Original Message-----
> From: kernel test robot <lkp@...el.com>
> Sent: Tuesday, May 3, 2022 06:18
> To: Limonciello, Mario <Mario.Limonciello@....com>
> Cc: kbuild-all@...ts.01.org; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; Hans de Goede
> <hdegoede@...hat.com>; linux-kernel@...r.kernel.org
> Subject: [RFC PATCH pdx86-platform-drivers-x86] platform/x86:
> thinkpad_acpi: quirk_btusb_bug can be static
> 
> drivers/platform/x86/thinkpad_acpi.c:317:20: warning: symbol
> 'quirk_btusb_bug' was not declared. Should it be static?
> 
> Fixes: 25eecc2ff6cc ("platform/x86: thinkpad_acpi: Convert btusb DMI list to
> quirks")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index aed17d32ed84b..eefa22e86ae10 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -314,7 +314,7 @@ struct quirk_entry {
>  	bool btusb_bug;
>  };
> 
> -struct quirk_entry quirk_btusb_bug = {
> +static struct quirk_entry quirk_btusb_bug = {
>  	.btusb_bug = true,
>  };
>