linux-kernel - Re: [PATCH v2] i2c: add support for microchip fpga i2c controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e6de466-eefc-c5f7-5db7-6a87ff1608ed@conchuod.ie>
Date:   Wed, 4 May 2022 17:17:43 +0100
From:   Conor Dooley <mail@...chuod.ie>
To:     Conor.Dooley@...rochip.com, wsa@...nel.org,
        linux-i2c@...r.kernel.org
Cc:     ben.dooks@...ethink.co.uk, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, Daire.McNamara@...rochip.com,
        geert@...ux-m68k.org
Subject: Re: [PATCH v2] i2c: add support for microchip fpga i2c controllers

On 04/05/2022 09:40, Conor.Dooley@...rochip.com wrote:
> On 21/03/2022 12:58, Conor Dooley wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> Add Microchip CoreI2C i2c controller support. This driver supports the
>> "hard" i2c controller on the Microchip PolarFire SoC & the basic feature
>> set for "soft" i2c controller implemtations in the FPGA fabric.
>>
>> Co-developed-by: Daire McNamara <daire.mcnamara@...rochip.com>
>> Signed-off-by: Daire McNamara <daire.mcnamara@...rochip.com>
>> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
>> ---
>> Changes from v1:
>> - Use byte write and read functions
> 
> So it turns out that how I made this change, which worked in my
> test app, has issues.
> I will rework and send a v3.
> 

Welp, as it turns out we can chalk the issues up to user error,
aka me entirely forgetting what the correct i2cdetect options
were - d'oh.

Apologies for the noise & unless something else changes, don't
expect a V3.

Sorry,
Conor.