linux-kernel - [PATCH] tools/edid: Only include the .data section in the raw binary output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220504002444.114011-1-cyrozap@gmail.com>
Date:   Tue,  3 May 2022 19:24:43 -0500
From:   Forest Crossman <cyrozap@...il.com>
To:     C.Emde@...dl.org, corbet@....net
Cc:     Forest Crossman <cyrozap@...il.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] tools/edid: Only include the .data section in the raw binary output

I don't know at what point this changed, but with gcc 11.2.0 and
binutils 2.38, if we don't restrict what sections are output to the raw
binary, the ".note.gnu.property" section in the object file will be
written into the first 48 bytes of the EDID, rendering it unusable.

To fix this, limit the binary output to the ".data" section.

Signed-off-by: Forest Crossman <cyrozap@...il.com>
---
 tools/edid/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/edid/Makefile b/tools/edid/Makefile
index 85a927dfab02..b62bfd925348 100644
--- a/tools/edid/Makefile
+++ b/tools/edid/Makefile
@@ -16,7 +16,7 @@ clean:
 	@cc -c $^
 
 %.bin.nocrc:	%.o
-	@objcopy -Obinary $^ $@
+	@objcopy -j.data -Obinary $^ $@
 
 %.crc:	%.bin.nocrc
 	@list=$$(for i in `seq 1 127`; do head -c$$i $^ | tail -c1 \
@@ -27,10 +27,10 @@ clean:
 	@cc -c -DCRC="$$(cat $*.crc)" -o $@ $*.S
 
 %.bin:	%.p
-	@objcopy -Obinary $^ $@
+	@objcopy -j.data -Obinary $^ $@
 
 %.bin.ihex:	%.p
-	@objcopy -Oihex $^ $@
+	@objcopy -j.data -Oihex $^ $@
 	@dos2unix $@ 2>/dev/null
 
 %.c:	%.bin
-- 
2.36.0