linux-kernel - Re: [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3

Open Source and information security mailing list archives

Date:   Wed, 4 May 2022 12:06:58 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Felix Fietkau <nbd@....name>
Cc:     Ryder Lee <ryder.lee@...iatek.com>,
        Jianjun Wang <jianjun.wang@...iatek.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-pci@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: mediatek-gen3: change driver name to mtk-pcie-gen3

On Wed, May 04, 2022 at 12:05:55PM +0200, Felix Fietkau wrote:
> This allows it to coexist with the other mtk pcie driver in the same kernel

I assume this is a v3 of [1].  Please:

  - Follow the subject line capitalization convention, i.e.,
    "PCI: mediatek-gen3: Change ..."

  - Expand the commit log to say why this is important.  From a C
    language level, using the same "mtk-pcie" string in both drivers
    is no problem.  So please mention where it *is* a problem, e.g.,
    if it's a problem with modprobe or similar, say that.  Or if it's
    to make log messages in dmesg have different driver names, say
    that.

  - s/pcie/PCIe/ in commit log and other English text.

  - Add a period at the end of the commit log sentence.

[1] https://lore.kernel.org/r/20220422070908.14043-1-jianjun.wang@mediatek.com

> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 3e8d70bfabc6..2e665cd7e735 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
>  	.probe = mtk_pcie_probe,
>  	.remove = mtk_pcie_remove,
>  	.driver = {
> -		.name = "mtk-pcie",
> +		.name = "mtk-pcie-gen3",
>  		.of_match_table = mtk_pcie_of_match,
>  		.pm = &mtk_pcie_pm_ops,
>  	},
> -- 
> 2.35.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives