linux-kernel - Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220504172417.GE1623@bug>
Date:   Wed, 4 May 2022 19:24:17 +0200
From:   Pavel Machek <pavel@....cz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Markuss Broks <markuss.broks@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        phone-devel@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
        <devicetree@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>, Andy
        Shevchenko <andy.shevchenko@...il.com>," 
        <~postmarketos/upstreaming@...ts.sr.ht>,
        Rob Herring <robh+dt@...nel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 2/2] leds: ktd2692: Make aux-gpios optional

Hi!

> > Make the AUX pin optional, since it isn't a core part of functionality,
> > and the device is designed to be operational with only one CTRL pin.
> >
> > Also pick up maintenance for the LED driver and the yaml bindings.
> 
> It's polite to Cc reviewers of your previous versions of the series.
> 
> While this patch is fine to me, Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> 
> one comment below.

Thanks for review.

Markuss, can you collect review tags and post v7?. Please drop MAINTAINERS part for now.

And sorry for delays.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html