linux-kernel - Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for onboard LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220504172507.GH1623@bug>
Date:   Wed, 4 May 2022 19:25:07 +0200
From:   Pavel Machek <pavel@....cz>
To:     Aparna M <a-m1@...com>, nm@...com, vigneshr@...com,
        kristo@...nel.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, praneeth@...com,
        grygorii.strashko@...com, nikhil.nd@...com,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for
 onboard LEDs

Hi!

> > +		led-7 {
> > +			color = <LED_COLOR_ID_AMBER>;
> > +			function = LED_FUNCTION_INDICATOR;
> > +			function-enumerator = <8>;
> > +			linux,default-trigger = "heartbeat";
> > +			gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> > +		};
> 
> This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
> author's personal preferences?

You are right that having 8 leds marked as indicator is not too useful.

> I added the linux-leds list to Cc.

Thank you!
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html