linux-kernel - Re: [RESEND PATCH] module: show disallowed symbol name for inherit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnLmi26EBEFJM5aH@bombadil.infradead.org>
Date:   Wed, 4 May 2022 13:48:11 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Lecopzer Chen <lecopzer.chen@...iatek.com>
Cc:     linux-kernel@...r.kernel.org,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-modules@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        yj.chiang@...iatek.com, atomlin@...hat.com
Subject: Re: [RESEND PATCH] module: show disallowed symbol name for
 inherit_taint()

On Wed, Apr 27, 2022 at 03:36:06PM +0800, Lecopzer Chen wrote:
> The error log for inherit_taint() doesn't really help to find the
> symbol which violates GPL rules.
> 
> For example,
> if a module has 300 symbol and includes 50 disallowed symbols,
> the log only shows the content below and we have no idea what symbol is.
>     AAA: module using GPL-only symbols uses symbols from proprietary module BBB.
> 
> It's hard for user who doesn't really know how the symbol was parsing.
> 
> This patch add symbol name to tell the offending symbols explicitly.
>     AAA: module using GPL-only symbols uses symbols SSS from proprietary module BBB.
> 
> Signed-off-by: Lecopzer Chen <lecopzer.chen@...iatek.com>

Thanks, pushed onto modules-testing. If there are no issues I'll
eventually push this onto modules-next.

  Luis