linux-kernel - Re: [PATCH sysctl-next] reboot: Fix build warning without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnLpIvXoFrCwnXTy@bombadil.infradead.org>
Date:   Wed, 4 May 2022 13:59:14 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     tangmeng@...ontech.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH sysctl-next] reboot: Fix build warning without
 CONFIG_SYSFS

On Wed, Apr 27, 2022 at 08:54:01PM +0800, YueHaibing wrote:
> If CONFIG_SYSFS is n, build warn:
> 
> kernel/reboot.c:443:20: error: ‘kernel_reboot_sysctls_init’ defined but not used [-Werror=unused-function]
>  static void __init kernel_reboot_sysctls_init(void)
>                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Move kernel_reboot_sysctls_init() to #ifdef block to fix this.
> 
> Fixes: 06d177662fb8 ("kernel/reboot: move reboot sysctls to its own file")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks! Merged and pushed onto sysctl-testing. If there are no issues I'll move
it to sysctl-next.

  Luis