linux-kernel - Re: [PATCH v2 01/26] modpost: use bool type where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAS1ZoTufXU4xwHz5BNyAOX698opRnQvfNR8he7+b+j8vQ@mail.gmail.com>
Date:   Wed, 4 May 2022 14:47:59 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH v2 01/26] modpost: use bool type where appropriate

On Wed, May 4, 2022 at 6:43 AM Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>
> On Sun, May 1, 2022 at 1:42 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h
> > index 96d6b3a16ca2..7ccfcc8899c1 100644
> > --- a/scripts/mod/modpost.h
> > +++ b/scripts/mod/modpost.h
> > @@ -1,4 +1,5 @@
> >  /* SPDX-License-Identifier: GPL-2.0 */
> > +#include <stdbool.h>
> >  #include <stdio.h>
> >  #include <stdlib.h>
> >  #include <stdarg.h>
> > @@ -111,11 +112,10 @@ struct module {
> >         struct module *next;
> >         int gpl_compatible;
> >         struct symbol *unres;
> > -       int from_dump;  /* 1 if module was loaded from *.symvers */
> > -       int is_vmlinux;
> > -       int seen;
> > -       int has_init;
> > -       int has_cleanup;
> > +       bool from_dump;         /* true if module was loaded from *.symvers */
> > +       bool is_vmlinux;
> > +       bool seen;
> > +       bool has_init, has_cleanup;
>
> Consider keeping these on separate lines. Either way:

OK, I will keep them on separate lines.




> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
> --
> Thanks,
> ~Nick Desaulniers



-- 
Best Regards
Masahiro Yamada