lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 May 2022 17:40:53 -0500 From: "Eric W. Biederman" <ebiederm@...ssion.com> To: linux-kernel@...r.kernel.org Cc: rjw@...ysocki.net, Oleg Nesterov <oleg@...hat.com>, mingo@...nel.org, vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org, mgorman@...e.de, bigeasy@...utronix.de, Will Deacon <will@...nel.org>, tj@...nel.org, linux-pm@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>, Richard Weinberger <richard@....at>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, Johannes Berg <johannes@...solutions.net>, linux-um@...ts.infradead.org, Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, linux-xtensa@...ux-xtensa.org, Kees Cook <keescook@...omium.org>, Jann Horn <jannh@...gle.com>, linux-ia64@...r.kernel.org, "Eric W. Biederman" <ebiederm@...ssion.com> Subject: [PATCH v3 06/11] signal: Use lockdep_assert_held instead of assert_spin_locked The distinction is that assert_spin_locked() checks if the lock is held *by*anyone* whereas lockdep_assert_held() asserts the current context holds the lock. Also, the check goes away if you build without lockdep. Suggested-by: Peter Zijlstra <peterz@...radead.org> Link: https://lkml.kernel.org/r/Ympr/+PX4XgT/UKU@hirez.programming.kicks-ass.net Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com> --- kernel/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index 72d96614effc..3fd2ce133387 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -884,7 +884,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info, static void ptrace_trap_notify(struct task_struct *t) { WARN_ON_ONCE(!(t->ptrace & PT_SEIZED)); - assert_spin_locked(&t->sighand->siglock); + lockdep_assert_held(&t->sighand->siglock); task_set_jobctl_pending(t, JOBCTL_TRAP_NOTIFY); ptrace_signal_wake_up(t, t->jobctl & JOBCTL_LISTENING); @@ -1079,7 +1079,7 @@ static int __send_signal_locked(int sig, struct kernel_siginfo *info, int override_rlimit; int ret = 0, result; - assert_spin_locked(&t->sighand->siglock); + lockdep_assert_held(&t->sighand->siglock); result = TRACE_SIGNAL_IGNORED; if (!prepare_signal(sig, t, force)) -- 2.35.3
Powered by blists - more mailing lists