linux-kernel - Re: [PATCH v4] zram: remove double compression logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnMGGMitdYg/5e4z@google.com>
Date:   Wed, 4 May 2022 16:02:48 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Alexey Romanov <avromanov@...rdevices.ru>
Cc:     ngupta@...are.org, senozhatsky@...omium.org,
        linux-block@...r.kernel.org, axboe@...omium.org,
        kernel@...rdevices.ru, linux-kernel@...r.kernel.org,
        mnitenko@...il.com, Dmitry Rokosov <ddrokosov@...rdevices.ru>
Subject: Re: [PATCH v4] zram: remove double compression logic

On Wed, May 04, 2022 at 03:12:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been
> used to prevent regression of allocation failure. However, it
> makes trouble for maintenance without significant benefit.
> The slowpath branch is executed extremely rarely: getting
> there is problematic. Therefore, we delete this branch.

Let's add about the stable_write, too in the description.

"Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
buffer change between 1st and 2nd memory allocations. Since we remove
second trial memory allocation logic, we could remove the STABLE_WRITES
flag because there is no change buffer to be modified under us"

> 
> Signed-off-by: Alexey Romanov <avromanov@...rdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>

Other than that, looks good to me.

Acked-by: Minchan Kim <minchan@...nel.org>

Please send the updated patch again with To: Andrew Morton <akpm@...ux-foundation.org>
with keeping Ccing.