linux-kernel - Re: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnIqofjeR+Q5FvgH@li-6e1fa1cc-351b-11b2-a85c-b897023bb5f3.ibm.com>
Date:   Wed, 4 May 2022 12:56:25 +0530
From:   Jagdish Gediya <jvgediya@...ux.ibm.com>
To:     Davidlohr Bueso <dave@...olabs.net>
Cc:     linux-mm@...ck.org, mhocko@...nel.org, akpm@...ux-foundation.org,
        rientjes@...gle.com, yosryahmed@...gle.com, hannes@...xchg.org,
        shakeelb@...gle.com, dave.hansen@...ux.intel.com,
        tim.c.chen@...ux.intel.com, roman.gushchin@...ux.dev,
        gthelen@...gle.com, a.manzanares@...sung.com,
        heekwon.p@...sung.com, gim.jongmin@...sung.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node_reclaim

On Fri, Apr 15, 2022 at 10:38:58PM -0700, Davidlohr Bueso wrote:
> We have helpers for a reason.
> 
> Signed-off-by: Davidlohr Bueso <dave@...olabs.net>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 1678802e03e7..cb583fcbf5bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -4750,7 +4750,7 @@ int node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned int order)
>  	 * over remote processors and spread off node memory allocations
>  	 * as wide as possible.
>  	 */
> -	if (node_state(pgdat->node_id, N_CPU) && pgdat->node_id != numa_node_id())
> +	if (node_is_toptier(pgdat->node_id) && pgdat->node_id != numa_node_id())
Currently node_is_toptier returns all N_CPU node as toptier but N_CPU
node will not stay necessarily top tier as per discussions on below
thread.

https://lore.kernel.org/linux-mm/CAAPL-u9sVx94ACSuCVN8V0tKp+AMxiY89cro0japtyB=xNfNBw@mail.gmail.com/

node_is_toptier() definition can change based on the discussion in above
thread.
>  		return NODE_RECLAIM_NOSCAN;
>  
>  	if (test_and_set_bit(PGDAT_RECLAIM_LOCKED, &pgdat->flags))
> -- 
> 2.26.2
> 
>