linux-kernel - Re: [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41eb4b05c703d0377b7139ad0868cebea8f6fc47.camel@mediatek.com>
Date:   Wed, 4 May 2022 15:49:30 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <matthias.bgg@...il.com>
CC:     <chunkuang.hu@...nel.org>, <airlied@...ux.ie>,
        Abaci Robot <abaci@...ux.alibaba.com>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] drm: mediatek: mtk_dsi: Remove unnecessary print
 function dev_err()

Hi, Yang:

On Thu, 2022-02-24 at 09:23 +0800, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/mediatek/mtk_dsi.c:1092:2-9: line 1092 is redundant
> because platform_get_irq() already prints an error

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index bced4c7d668e..704252ee1198 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1089,7 +1089,6 @@ static int mtk_dsi_probe(struct platform_device
> *pdev)
>  
>  	irq_num = platform_get_irq(pdev, 0);
>  	if (irq_num < 0) {
> -		dev_err(&pdev->dev, "failed to get dsi irq_num: %d\n",
> irq_num);
>  		ret = irq_num;
>  		goto err_unregister_host;
>  	}