linux-kernel - Re: [PATCH] mmc: atmel-mci: Simplify if(chan) and if(!chan)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFoCTX3E-D2OW_YMp0EJ2y872e+Nd-0XtinBD0vmwHjSZw@mail.gmail.com>
Date:   Wed, 4 May 2022 12:37:22 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: atmel-mci: Simplify if(chan) and if(!chan)

On Wed, 27 Apr 2022 at 14:03, Wan Jiabing <wanjiabing@...o.com> wrote:
>
> Use if(!host->dma.chan) instead of if(chan) and if(!chan) to make
> code better.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/atmel-mci.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 807177c953f3..91d52ba7a39f 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -1122,13 +1122,12 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
>         }
>
>         /* If we don't have a channel, we can't do DMA */
> -       chan = host->dma.chan;
> -       if (chan)
> -               host->data_chan = chan;
> -
> -       if (!chan)
> +       if (!host->dma.chan)
>                 return -ENODEV;
>
> +       chan = host->dma.chan;
> +       host->data_chan = chan;
> +
>         if (data->flags & MMC_DATA_READ) {
>                 host->dma_conf.direction = slave_dirn = DMA_DEV_TO_MEM;
>                 maxburst = atmci_convert_chksize(host,
> --
> 2.35.3
>