linux-kernel - Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220504135516.36072ece@donnerap.cambridge.arm.com>
Date:   Wed, 4 May 2022 13:55:16 +0100
From:   Andre Przywara <andre.przywara@....com>
To:     IotaHydrae <writeforever@...mail.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: sunxi: fix f1c100s pinctrl function.

On Wed,  4 May 2022 19:59:04 +0800
IotaHydrae <writeforever@...mail.com> wrote:

Hi,

thanks for the patch!

I think the subject should start with: "pinctrl: sunxi:", also please
mention the UART in there.

> 1. change suniv f1c100s pinctrl,PD14 multiplexing function lvds1 to uart2
> 
> When the pin PD13 and PD14 is setting up to uart2 function in dts,
> there's an error occurred:
> 1c20800.pinctrl: unsupported function uart2 on pin PD14
> 
> Because 'uart2' is not any one multiplexing option of PD14,
> and pinctrl don't know how to configure it.
> 
> So change the pin PD14 lvds1 function to uart2.
> 
> Signed-off-by: IotaHydrae <writeforever@...mail.com>

Compared against the manual, looks correct:

Reviewed-by: Andre Przywara <andre.przywara@....com>

Cheers,
Andre

P.S. I used to opportunity to check all other functions as well, apart
from one error in the comments they were correct. Will send a patch.

> ---
>  drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> index 2801ca706273..68a5b627fb9b 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-suniv-f1c100s.c
> @@ -204,7 +204,7 @@ static const struct sunxi_desc_pin suniv_f1c100s_pins[] = {
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),
>  		  SUNXI_FUNCTION(0x1, "gpio_out"),
>  		  SUNXI_FUNCTION(0x2, "lcd"),		/* D20 */
> -		  SUNXI_FUNCTION(0x3, "lvds1"),		/* RX */
> +		  SUNXI_FUNCTION(0x3, "uart2"),		/* RX */
>  		  SUNXI_FUNCTION_IRQ_BANK(0x6, 0, 14)),
>  	SUNXI_PIN(SUNXI_PINCTRL_PIN(D, 15),
>  		  SUNXI_FUNCTION(0x0, "gpio_in"),