linux-kernel - Re: [PATCH 2/5] iommu/vt-d: Set SNP bit only in second-level page table entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16365887-3034-c4b8-da91-eee6a9f976b2@linux.intel.com>
Date:   Wed, 4 May 2022 22:37:07 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     Joerg Roedel <joro@...tes.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Jacob jun Pan <jacob.jun.pan@...el.com>,
        Liu Yi L <yi.l.liu@...el.com>,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] iommu/vt-d: Set SNP bit only in second-level page
 table entries

On 2022/5/4 21:31, Jason Gunthorpe wrote:
> On Wed, May 04, 2022 at 03:25:50PM +0800, Baolu Lu wrote:
>> Hi Jason,
>>
>> On 2022/5/2 21:05, Jason Gunthorpe wrote:
>>> On Sun, May 01, 2022 at 07:24:31PM +0800, Lu Baolu wrote:
>>>> The SNP bit is only valid for second-level PTEs. Setting this bit in the
>>>> first-level PTEs has no functional impact because the Intel IOMMU always
>>>> ignores the same bit in first-level PTEs. Anyway, let's check the page
>>>> table type before setting SNP bit in PTEs to make the code more readable.
>>> Shouldn't this be tested before setting force_snooping and not during
>>> every map?
>>
>> The check is in the following patch. This just makes sure that SNP is
>> only set in second-level page table entries.
> 
> I think you should add a 2nd flag to indicate 'set SNP bit in PTEs'
> and take care of computing that flag in the enforce_no_snoop function

Yours looks better. Will add it in the next version.

> Jason

Best regards,
baolu