linux-kernel - Re: [PATCH v2 1/4] MAINTAINERS: Add entries for Apple SoC cpufreq driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0445aa6-0c96-b80d-154e-274be0c1a025@marcan.st>
Date:   Wed, 4 May 2022 23:52:43 +0900
From:   Hector Martin <marcan@...can.st>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Mark Kettenis <mark.kettenis@...all.nl>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] MAINTAINERS: Add entries for Apple SoC cpufreq
 driver

On 04/05/2022 19.17, Viresh Kumar wrote:
> On 04-05-22, 16:51, Hector Martin wrote:
>> Splitting this commit, as usual, to facilitate merges via the SoC tree.
>>
>> Signed-off-by: Hector Martin <marcan@...can.st>
>> ---
>>  MAINTAINERS | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index edc96cdb85e8..39bfa478fe55 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1835,6 +1835,7 @@ T:	git https://github.com/AsahiLinux/linux.git
>>  F:	Documentation/devicetree/bindings/arm/apple.yaml
>>  F:	Documentation/devicetree/bindings/arm/apple/*
>>  F:	Documentation/devicetree/bindings/clock/apple,nco.yaml
>> +F:	Documentation/devicetree/bindings/cpufreq/apple,soc-cpufreq.yaml
>>  F:	Documentation/devicetree/bindings/i2c/apple,i2c.yaml
>>  F:	Documentation/devicetree/bindings/interrupt-controller/apple,*
>>  F:	Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>> @@ -1844,6 +1845,7 @@ F:	Documentation/devicetree/bindings/power/apple*
>>  F:	Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
>>  F:	arch/arm64/boot/dts/apple/
>>  F:	drivers/clk/clk-apple-nco.c
>> +F:	drivers/cpufreq/apple-soc-cpufreq.c
>>  F:	drivers/i2c/busses/i2c-pasemi-core.c
>>  F:	drivers/i2c/busses/i2c-pasemi-platform.c
>>  F:	drivers/irqchip/irq-apple-aic.c
> 
> This should be the last patch instead, or should at least be added
> after the files are merged first. If someone checks out at this
> commit, the files won't be available but still linked here.

Isn't that backwards? If someone touches the files, we want them to be
able to get_maintainer.pl, so the MAINTAINERS entries should come first.
It doesn't really cause any issues if there are entries that point at
files that don't exist yet, right?

Though this is mostly a moot point because the purpose of splitting this
out is so we can merge this one patch through the SoC tree, at which
point the ordering isn't guaranteed (unless the whole series goes
through SoC). It's a minor issue though; we've done it like this for
other series and it hasn't caused anyone trouble.

-- 
Hector Martin (marcan@...can.st)
Public Key: https://mrcn.st/pub