lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 May 2022 17:33:20 +0200 From: Frank Wunderlich <frank-w@...lic-files.de> To: Vladimir Oltean <olteanv@...il.com> Cc: Frank Wunderlich <linux@...web.de>, linux-mediatek@...ts.infradead.org, linux-rockchip@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Heiko Stuebner <heiko@...ech.de>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, Peter Geis <pgwipeout@...il.com>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Aw: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Hi, thanks for review > Gesendet: Mittwoch, 04. Mai 2022 um 17:24 Uhr > Von: "Vladimir Oltean" <olteanv@...il.com> > > +&mdio0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + switch@0 { > > I think the preferable names are the newer "ethernet-switch@0", > "ethernet-ports", "ethernet-port@0". > > Otherwise > > Reviewed-by: Vladimir Oltean <olteanv@...il.com> current device-tree nodes using "switch" and "ports" see discussioon here about make it fixed to "ports" property instead of PatternProperties including optional "ethernet-" https://patchwork.kernel.org/project/linux-mediatek/patch/20220502153238.85090-1-linux@fw-web.de/#24843155 > > > + compatible = "mediatek,mt7531"; > > + reg = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@1 { > > + reg = <1>; > > + label = "lan0"; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + label = "lan1"; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + label = "lan2"; > > + }; > > + > > + port@4 { > > + reg = <4>; > > + label = "lan3"; > > + }; > > + > > + port@5 { > > + reg = <5>; > > + label = "cpu"; > > + ethernet = <&gmac0>; > > + phy-mode = "rgmii"; > > + > > + fixed-link { > > + speed = <1000>; > > + full-duplex; > > + pause; > > + }; > > + }; > > + }; > > + };
Powered by blists - more mailing lists