linux-kernel - Re: [PATCH RESEND v6 (corrected v2) 2/2] leds: ktd2692: Make aux-gpios optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdfaP4ypVHdMZ=TgMVmd1ioak-0AUA9k+Z6wNAr458+ag@mail.gmail.com>
Date:   Wed, 4 May 2022 17:51:05 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Markuss Broks <markuss.broks@...il.com>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND v6 (corrected v2) 2/2] leds: ktd2692: Make
 aux-gpios optional

On Wed, May 4, 2022 at 5:38 PM Markuss Broks <markuss.broks@...il.com> wrote:
>
> Make the AUX pin optional, since it isn't a core part of functionality,
> and the device is designed to be operational with only one CTRL pin.
>
> Also pick up maintenance for the LED driver and the yaml bindings.


The MAINTAINERS update seems like it deserves a separate patch.
But most importantly, you need to add a patch that converts the error
reporting to use dev_err_probe(). Currently code has that issue, i.e.
it will print the error message as many times as probe was deferred
due to unreadiness of GPIO.

Something like this

>                 dev_err(dev, "cannot get aux-gpios %d\n", ret);
>                 return ret;

===>

  return dev_err_probe(dev, ret, "cannot get aux-gpios\n");

with a Fixes tag added.

-- 
With Best Regards,
Andy Shevchenko