linux-kernel - Re: [PATCH v5] zram: remove double compression logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 09:57:01 -0700
From:   Minchan Kim <minchan@...nel.org>
To:     Alexey Romanov <avromanov@...rdevices.ru>
Cc:     akpm@...ux-foundation.org, ngupta@...are.org,
        senozhatsky@...omium.org, linux-block@...r.kernel.org,
        axboe@...omium.org, kernel@...rdevices.ru,
        linux-kernel@...r.kernel.org, mnitenko@...il.com,
        Dmitry Rokosov <ddrokosov@...rdevices.ru>
Subject: Re: [PATCH v5] zram: remove double compression logic

On Thu, May 05, 2022 at 12:44:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been used to
> prevent regression of allocation failure. However, it makes trouble
> for maintenance without significant benefit. The slowpath branch is
> executed extremely rarely: getting there is problematic. Therefore,
> we delete this branch.
> 
> Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
> buffer change between 1st and 2nd memory allocations. Since we remove
> second trial memory allocation logic, we could remove the STABLE_WRITES
> flag because there is no change buffer to be modified under us.
> 
> Signed-off-by: Alexey Romanov <avromanov@...rdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@...rdevices.ru>

Acked-by: Minchan Kim <minchan@...nel.org>