linux-kernel - Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 10:10:54 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Wyes Karny <wyes.karny@....com>, linux-kernel@...r.kernel.org
Cc:     Lewis.Carroll@....com, Mario.Limonciello@....com,
        gautham.shenoy@....com, Ananth.Narayan@....com, bharata@....com,
        len.brown@...el.com, x86@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        hpa@...or.com, peterz@...radead.org, chang.seok.bae@...el.com,
        keescook@...omium.org, metze@...ba.org, zhengqi.arch@...edance.com,
        mark.rutland@....com, puwen@...on.cn, rafael.j.wysocki@...el.com,
        andrew.cooper3@...rix.com, jing2.liu@...el.com,
        jmattson@...gle.com, pawan.kumar.gupta@...ux.intel.com
Subject: Re: [PATCH v2 3/3] x86: Fix comment for X86_FEATURE_ZEN

On 5/5/22 04:04, Wyes Karny wrote:
> The feature X86_FEATURE_ZEN implies that the CPU supports Zen
> microarchitecture. Call this out explicitly in the comment.

Is "supports" the best word here?

A CPU is based on a microarchitecture, it doesn't really support it.  I
guess we could say the CPU supports a microarchitecture's *features*,
but that's a bit wordy for a tiny comment.

Maybe:

#define X86_FEATURE_ZEN			(7*32+28) /* "" CPU based on Zen uarch */

or spell out "microarchitecture" if there's room.