linux-kernel - Re: [PATCH -next] vt: defkeymap.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 11:10:55 +0800
From:   "zhangjianhua (E)" <chris.zjh@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     <jirislaby@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables


在 2022/4/29 14:39, Greg KH 写道:
> On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote:
>> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
>> been initialized but not used, they are redundant and remove them.
>>
>> --------
> Why this extra "------" line?

This line "------" means the end of commit message, if it is redundant, I will remove it in next version.

>> Signed-off-by: Zhang Jianhua <chris.zjh@...wei.com>
>> ---
>>   drivers/tty/vt/defkeymap.c_shipped | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
>> index 094d95bf0005..80dee50bcb7a 100644
>> --- a/drivers/tty/vt/defkeymap.c_shipped
>> +++ b/drivers/tty/vt/defkeymap.c_shipped
>> @@ -185,10 +185,6 @@ char func_buf[] = {
>>   	'\033', '[', 'P', 0,
>>   };
>>   
>> -char *funcbufptr = func_buf;
>> -int funcbufsize = sizeof(func_buf);
>> -int funcbufleft = 0;          /* space left */
>> -
>>   char *func_table[MAX_NR_FUNC] = {
>>   	func_buf + 0,
>>   	func_buf + 5,
>> -- 
>> 2.31.0
>>
> Shouldn't you fix up the loadkeys tool instead?  As the top of this file
> says, it is auto-generated and is not something to be hand-edited at
> all.
>
> thanks,
>
> greg k-h
> .
Thanks, I will read the source code more carefully, and fix up the 
loadkeys tool if it is indeed a problem.