linux-kernel - Re: [PATCH] selftests: vm: Makefile: rename TARGETS to VMTARGETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 May 2022 20:25:56 -0400
From:   Nico Pache <npache@...hat.com>
To:     Joel Savitz <jsavitz@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>,
        Sandipan Das <sandipan@...ux.ibm.com>,
        Dave Hansen <dave.hansen@...el.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: vm: Makefile: rename TARGETS to VMTARGETS



On 5/4/22 17:40, Joel Savitz wrote:
> The tools/testing/selftests/vm/Makefile uses the variable TARGETS
> internally to generate a list of platform-specific binary build targets
> suffixed with _{32,64}. When building the selftests using its own
> Makefile directly, such as via the following command run in a kernel
> tree:
> 
> # make -C tools/testing/selftests install TARGETS="vm"
> 
> One receives an error such as the following:
> 
> make: Entering directory '/root/linux/tools/testing/selftests'
> make --no-builtin-rules ARCH=x86 -C ../../.. headers_install
> make[1]: Entering directory '/root/linux'
>   INSTALL ./usr/include
> make[1]: Leaving directory '/root/linux'
> make[1]: Entering directory '/root/linux/tools/testing/selftests/vm'
> make[1]: *** No rule to make target 'vm.c', needed by '/root/linux/tools/testing/selftests/vm/vm_64'.  Stop.
> make[1]: Leaving directory '/root/linux/tools/testing/selftests/vm'
> make: *** [Makefile:175: all] Error 2
> make: Leaving directory '/root/linux/tools/testing/selftests'
> 
> The TARGETS variable passed to tools/testing/selftests/Makefile collides
> with the TARGETS used in tools/testing/selftests/vm/Makefile, so rename
> the latter to VMTARGETS, eliminating the collision with no functional
> change.
> 
> Fixes: f21fda8f6453 ("selftests: vm: pkeys: fix multilib builds for
> x86")
> 
> Signed-off-by: Joel Savitz <jsavitz@...hat.comTested-by: Nico Pache <npache@...hat.com>
Acked-by: Nico Pache <npache@...hat.com>