linux-kernel - Re: [PATCH] staging: octeon-usb: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 23:16:15 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Artur Bujdoso <artur.bujdoso@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: octeon-usb: remove unnecessary parentheses

On Thu, Apr 28, 2022 at 02:14:17PM +0200, Artur Bujdoso wrote:
> On Fri, Apr 08, 2022 at 10:13:58AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Apr 08, 2022 at 09:30:37AM +0200, Artur Bujdoso wrote:
> > > Adhere to Linux kernel coding style.
> > > 
> > > Reported by checkpatch:
> > > 
> > > CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses
> > > 
> > > Signed-off-by: Artur Bujdoso <artur.bujdoso@...il.com>
> > > ---
> > >  drivers/staging/octeon-usb/octeon-hcd.c | 62 ++++++++++++-------------
> > >  1 file changed, 31 insertions(+), 31 deletions(-)
> > > 
> > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> > > index a1cd81d4a114..32bcd6c582f5 100644
> > > --- a/drivers/staging/octeon-usb/octeon-hcd.c
> > > +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> > > @@ -1101,9 +1101,9 @@ static struct cvmx_usb_pipe *cvmx_usb_open_pipe(struct octeon_hcd *usb,
> > >  	pipe = kzalloc(sizeof(*pipe), GFP_ATOMIC);
> > >  	if (!pipe)
> > >  		return NULL;
> > > -	if ((device_speed == CVMX_USB_SPEED_HIGH) &&
> > > -	    (transfer_dir == CVMX_USB_DIRECTION_OUT) &&
> > > -	    (transfer_type == CVMX_USB_TRANSFER_BULK))
> > > +	if (device_speed == CVMX_USB_SPEED_HIGH &&
> > > +	    transfer_dir == CVMX_USB_DIRECTION_OUT &&
> > > +	    transfer_type == CVMX_USB_TRANSFER_BULK)
> > >  		pipe->flags |= CVMX_USB_PIPE_FLAGS_NEED_PING;
> > 
> > Nah, the original is fine, no need to change this.
> > 
> > Unless, do you have this hardware?  If so, getting this out of staging
> > would be nice to have happen one day.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi,
> 
> So I do have the hardware, an Ubiquiti Edgerouter POE. This has a Cavium Octeon+ SoC and a single USB port.
> This is used for booting and for rootfs (in a form of a squasfs image) and configuration.
> 
> I cross-compiled an unmodified kernel with a sufficient configuration - with the octeon-usb driver added - to get to user space.
> I am not sure how should I present it - sorry in advance if it's not the right way - so here is the boot log as it happened. 
> 
> I should note that I tried to plug in other devices such as usb pendrives, wifi dongles, a hub and even an Elgato card, all showed up.
> Partitions were also detected on all usb drives, all of them had some sort of FAT partitions with MBR.
> 
> What else can I help with to get this driver out of staging?

Is it checkpatch and sparse clean?  If so, then propose a patch that
adds it to the proper place in the kernel tree and we can go from there.

thanks,

greg k-h