linux-kernel - Re: [PATCH v1 2/3] kallsyms: support "big" kernel symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 16:47:35 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Miguel Ojeda <ojeda@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, Song Liu <song@...nel.org>,
        Bixuan Cui <cuibixuan@...wei.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        David Vernet <void@...ifault.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Changbin Du <changbin.du@...el.com>,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...gle.com>,
        Gary Guo <gary@...yguo.net>, Boqun Feng <boqun.feng@...il.com>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v1 2/3] kallsyms: support "big" kernel symbols

On Thu, May 05, 2022 at 09:16:44PM +0200, Miguel Ojeda wrote:
> Rust symbols can become quite long due to namespacing introduced
> by modules, types, traits, generics, etc.
> 
> Increasing to 255 is not enough in some cases, and therefore
> we need to introduce longer lengths to the symbol table.
> 
> In order to avoid increasing all lengths to 2 bytes (since most
> of them are small, including many Rust ones), we use ULEB128 to
> keep smaller symbols in 1 byte, with the rest in 2 bytes.
> 
> Co-developed-by: Alex Gaynor <alex.gaynor@...il.com>
> Signed-off-by: Alex Gaynor <alex.gaynor@...il.com>
> Co-developed-by: Wedson Almeida Filho <wedsonaf@...gle.com>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@...gle.com>
> Co-developed-by: Gary Guo <gary@...yguo.net>
> Signed-off-by: Gary Guo <gary@...yguo.net>
> Co-developed-by: Boqun Feng <boqun.feng@...il.com>
> Signed-off-by: Boqun Feng <boqun.feng@...il.com>
> Co-developed-by: Matthew Wilcox <willy@...radead.org>
> Signed-off-by: Matthew Wilcox <willy@...radead.org>
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Looks good to me.

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook