lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 May 2022 09:31:40 +0900 From: Masami Hiramatsu <mhiramat@...nel.org> To: Max Filippov <jcmvbkbc@...il.com> Cc: Steven Rostedt <rostedt@...dmis.org>, "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>, "David S . Miller" <davem@...emloft.net>, Peter Zijlstra <peterz@...radead.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] kprobes: Fix build errors with CONFIG_KRETPROBES=n On Wed, 4 May 2022 10:53:42 -0700 Max Filippov <jcmvbkbc@...il.com> wrote: > On Tue, May 3, 2022 at 8:36 PM Masami Hiramatsu <mhiramat@...nel.org> wrote: > > > > Max Filippov reported: > > > > When building kernel with CONFIG_KRETPROBES=n kernel/kprobes.c > > compilation fails with the following messages: > > > > kernel/kprobes.c: In function ‘recycle_rp_inst’: > > kernel/kprobes.c:1273:32: error: implicit declaration of function > > ‘get_kretprobe’ > > > > kernel/kprobes.c: In function ‘kprobe_flush_task’: > > kernel/kprobes.c:1299:35: error: ‘struct task_struct’ has no member > > named ‘kretprobe_instances’ > > > > This came from the commit d741bf41d7c7 ("kprobes: Remove > > kretprobe hash") which introduced get_kretprobe() and > > kretprobe_instances member in task_struct when CONFIG_KRETPROBES=y, > > but did not make recycle_rp_inst() and kprobe_flush_task() > > depending on CONFIG_KRETPORBES. > > > > Since those functions are only used for kretprobe, move those > > functions into #ifdef CONFIG_KRETPROBE area. > > > > Reported-by: Max Filippov <jcmvbkbc@...il.com> > > Fixes: d741bf41d7c7 ("kprobes: Remove kretprobe hash") > > Cc: stable@...r.kernel.org > > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org> > > --- > > include/linux/kprobes.h | 2 - > > kernel/kprobes.c | 144 +++++++++++++++++++++++------------------------ > > 2 files changed, 72 insertions(+), 74 deletions(-) > > Tested-by: Max Filippov <jcmvbkbc@...il.com> Thank you! Steve, can you pick this fix? Thanks, -- Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists