linux-kernel - Re: [PATCH] drm: simplify the return expression of ast_drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 09:32:35 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     cgel.zte@...il.com, airlied@...hat.com
Cc:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drm: simplify the return expression of ast_drm_resume()

Hi

Am 05.05.22 um 04:22 schrieb cgel.zte@...il.com:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Simplify the return expression.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

Thanks a lot. I added your patch to drm-misc-next.

Best regards
Thomas

> ---
>   drivers/gpu/drm/ast/ast_drv.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
> index 7465c4f0156a..760b27971557 100644
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -159,15 +159,10 @@ static int ast_drm_thaw(struct drm_device *dev)
>   
>   static int ast_drm_resume(struct drm_device *dev)
>   {
> -	int ret;
> -
>   	if (pci_enable_device(to_pci_dev(dev->dev)))
>   		return -EIO;
>   
> -	ret = ast_drm_thaw(dev);
> -	if (ret)
> -		return ret;
> -	return 0;
> +	return ast_drm_thaw(dev);
>   }
>   
>   static int ast_pm_suspend(struct device *dev)

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)