linux-kernel - Re: [PATCH] dmaengine: tegra: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 10:18:19 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Akhil R <akhilrajeev@...dia.com>, dmaengine@...r.kernel.org,
        ldewangan@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, p.zabel@...gutronix.de,
        thierry.reding@...il.com, vkoul@...nel.org
Subject: Re: [PATCH] dmaengine: tegra: Use platform_get_irq() to get IRQ
 resource


On 05/05/2022 10:14, Akhil R wrote:
> Use platform_irq_get() instead platform_get_resource() for IRQ resource
> to fix the probe failure. platform_get_resource() fails to fetch the IRQ
> resource as it might not be ready at that time.
> 
> platform_irq_get() is also the recommended way to get interrupt as it
> directly gives the IRQ number and no conversion from resource is
> required.
> 
> Fixes: ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
> Reported-by: Jonathan Hunter <jonathanh@...dia.com>
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>   drivers/dma/tegra186-gpc-dma.c | 12 ++++--------
>   1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/dma/tegra186-gpc-dma.c b/drivers/dma/tegra186-gpc-dma.c
> index 97fe0e9e9b83..3951db527dec 100644
> --- a/drivers/dma/tegra186-gpc-dma.c
> +++ b/drivers/dma/tegra186-gpc-dma.c
> @@ -1328,7 +1328,6 @@ static int tegra_dma_probe(struct platform_device *pdev)
>   	struct iommu_fwspec *iommu_spec;
>   	unsigned int stream_id, i;
>   	struct tegra_dma *tdma;
> -	struct resource	*res;
>   	int ret;
>   
>   	cdata = of_device_get_match_data(&pdev->dev);
> @@ -1367,16 +1366,13 @@ static int tegra_dma_probe(struct platform_device *pdev)
>   	for (i = 0; i < cdata->nr_channels; i++) {
>   		struct tegra_dma_channel *tdc = &tdma->channels[i];
>   
> +		tdc->irq = platform_get_irq(pdev, i);
> +		if (tdc->irq < 0)
> +			return tdc->irq;
> +
>   		tdc->chan_base_offset = TEGRA_GPCDMA_CHANNEL_BASE_ADD_OFFSET +
>   					i * cdata->channel_reg_size;
> -		res = platform_get_resource(pdev, IORESOURCE_IRQ, i);
> -		if (!res) {
> -			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
> -			return -EINVAL;
> -		}
> -		tdc->irq = res->start;
>   		snprintf(tdc->name, sizeof(tdc->name), "gpcdma.%d", i);
> -
>   		tdc->tdma = tdma;
>   		tdc->id = i;
>   		tdc->slave_id = -1;


Thanks!

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Jon

-- 
nvpublic