linux-kernel - Re: [PATCH v3] [PATCH v3] uwb: nxp: sr1xx: UWB driver support for sr1xx series chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 18:06:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Manjunatha Venkatesh <manjunatha.venkatesh@....com>,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        will@...nel.org, axboe@...nel.dk
Cc:     kbuild-all@...ts.01.org, mb@...htnvm.io,
        ckeepax@...nsource.cirrus.com, manjunatha.venkatesh@....com,
        mst@...hat.com, javier@...igon.com, mikelley@...rosoft.com,
        jasowang@...hat.com, sunilmut@...rosoft.com,
        bjorn.andersson@...aro.org, rvmanjumce@...il.com,
        ashish.deshpande@....com
Subject: Re: [PATCH v3] [PATCH v3] uwb: nxp: sr1xx: UWB driver support for
 sr1xx series chip

Hi Manjunatha,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on linux/master linus/master v5.18-rc5 next-20220504]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Manjunatha-Venkatesh/uwb-nxp-sr1xx-UWB-driver-support-for-sr1xx-series-chip/20220505-020126
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 35a7609639c49f76f13f206402cbf692c4ae3e4e
config: sparc-buildonly-randconfig-r005-20220505 (https://download.01.org/0day-ci/archive/20220505/202205051830.f36qJQ6E-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/037b22462c3f4715f0a04e1be05cd12986880d21
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Manjunatha-Venkatesh/uwb-nxp-sr1xx-UWB-driver-support-for-sr1xx-series-chip/20220505-020126
        git checkout 037b22462c3f4715f0a04e1be05cd12986880d21
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/misc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/sr1xx.c:125:6: warning: no previous prototype for 'sr1xx_wait_for_irq_gpio_low' [-Wmissing-prototypes]
     125 | void sr1xx_wait_for_irq_gpio_low(struct sr1xx_dev *sr1xx_dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/sr1xx.c:720:5: warning: no previous prototype for 'sr1xx_dev_suspend' [-Wmissing-prototypes]
     720 | int sr1xx_dev_suspend(struct device *dev)
         |     ^~~~~~~~~~~~~~~~~
>> drivers/misc/sr1xx.c:736:5: warning: no previous prototype for 'sr1xx_dev_resume' [-Wmissing-prototypes]
     736 | int sr1xx_dev_resume(struct device *dev)
         |     ^~~~~~~~~~~~~~~~


vim +/sr1xx_wait_for_irq_gpio_low +125 drivers/misc/sr1xx.c

   118	
   119	/**
   120	 * sr1xx_wait_for_irq_gpio_low
   121	 *
   122	 * Function to wait till irq gpio goes low state
   123	 *
   124	 */
 > 125	void sr1xx_wait_for_irq_gpio_low(struct sr1xx_dev *sr1xx_dev)
   126	{
   127		int retry_count = 0;
   128	
   129		do {
   130			udelay(10);
   131			retry_count++;
   132			if (retry_count == MAX_RETRY_COUNT_FOR_HANDSHAKE) {
   133				dev_info(&sr1xx_dev->spi->dev,
   134					 "Slave not released the IRQ even after 10ms");
   135				break;
   136			}
   137		} while (gpio_get_value(sr1xx_dev->irq_gpio));
   138	}
   139	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp