linux-kernel - Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d30b811-b452-cbf0-a3e3-00e400ba76ef@suse.com>
Date:   Thu, 5 May 2022 12:21:55 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     monish.kumar.r@...el.com, gregkh@...uxfoundation.org,
        olebowle@....com, oneukum@...e.com, vpalatin@...omium.org,
        wangjm221@...il.com, chris.chiu@...onical.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
CC:     abhijeet.rao@...el.com
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for
 Dell usb gen 2 device to not fail during enumeration.



On 05.05.22 12:14, monish.kumar.r@...el.com wrote:
> From: Monish Kumar R <monish.kumar.r@...el.com>
>
> Signed-off-by: Monish Kumar R <monish.kumar.r@...el.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>  
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
>         
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME },
>  
>

Hi,

could you please

1) keep the list in nummerical order from lowest device ID to largest
2) combine both quirks with a binary OR
3) provide a short reason for this patch like "found in own testing" or
"reported on list"

    Regards
        Oliver