[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 5 May 2022 13:05:11 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Heiko Stübner <heiko@...ech.de>
Cc: Arnd Bergmann <arnd@...db.de>,
linux-riscv <linux-riscv@...ts.infradead.org>,
Guo Ren <guoren@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
Waiman Long <longman@...hat.com>,
Boqun Feng <boqun.feng@...il.com>,
Jonas Bonn <jonas@...thpole.se>,
Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
Stafford Horne <shorne@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Greg KH <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
"Maciej W. Rozycki" <macro@...am.me.uk>,
Jisheng Zhang <jszhang@...nel.org>, linux-csky@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Openrisc <openrisc@...ts.librecores.org>,
linux-arch <linux-arch@...r.kernel.org>,
Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: [PATCH v4 2/7] asm-generic: qspinlock: Indicate the use of
mixed-size atomics
On Wed, May 4, 2022 at 2:02 PM Heiko Stübner <heiko@...ech.de> wrote:
> > index d74b13825501..95be3f3c28b5 100644
> > --- a/include/asm-generic/qspinlock.h
> > +++ b/include/asm-generic/qspinlock.h
> > @@ -2,6 +2,37 @@
> > /*
> > * Queued spinlock
> > *
> > + * A 'generic' spinlock implementation that is based on MCS locks. An
>
> _For_ an architecture that's ... ?
>
> > + * architecture that's looking for a 'generic' spinlock, please first consider
> > + * ticket-lock.h and only come looking here when you've considered all the
> > + * constraints below and can show your hardware does actually perform better
> > + * with qspinlock.
> > + *
> > + *
>
> double empty line is probably not necessary
>
I've applied the series to the asm-generic tree now, and edited both the above
as you suggested in the process, to save Palmer the v5.
Arnd
Powered by blists - more mailing lists