linux-kernel - Re: [PATCH v3 1/2] usb: serial: option: Add Fibocom L610 modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 13:40:41 +0200
From:   Johan Hovold <johan@...nel.org>
To:     sven@...nschwermer.de
Cc:     linux-usb@...r.kernel.org,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] usb: serial: option: Add Fibocom L610 modem

On Mon, Apr 25, 2022 at 04:34:49PM +0200, sven@...nschwermer.de wrote:
> From: Sven Schwermer <sven.schwermer@...ruptive-technologies.com>
> 
> The L610 modem has 3 USB configurations that are configurable via the AT
> command AT+GTUSBMODE={31,32,33} which make the modem enumerate with the
> following interfaces, respectively:
> 
> 31: Modem + NV + MOS + Diag + LOG + AT + AT
> 32: ECM + Modem + NV + MOS + Diag + LOG + AT + AT
> 33: RNDIS + Modem + NV + MOS + Diag + LOG + AT + AT
> 
> A detailed description of the USB configuration for each mode follows:

[...]

> Signed-off-by: Sven Schwermer <sven.schwermer@...ruptive-technologies.com>
> ---
> V2 -> V3: Add this changelog
> V1 -> V2: Use USB_DEVICE_INTERFACE_CLASS, add comments

Perfect, thanks for the update!

>  drivers/usb/serial/option.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index e7755d9cfc61..e0af45e3a6f7 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -2111,6 +2111,8 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(3) },
>  	{ USB_DEVICE(0x1508, 0x1001),						/* Fibocom NL668 (IOT version) */
>  	  .driver_info = RSVD(4) | RSVD(5) | RSVD(6) },
> +	{ USB_DEVICE(0x1782, 0x4d10) },						/* Fibocom L610 (AT mode) */
> +	{ USB_DEVICE_INTERFACE_CLASS(0x1782, 0x4d11, 0xff) },			/* Fibocom L610 (ECM/RNDIS mode) */
>  	{ USB_DEVICE(0x2cb7, 0x0104),						/* Fibocom NL678 series */
>  	  .driver_info = RSVD(4) | RSVD(5) },
>  	{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x0105, 0xff),			/* Fibocom NL678 series */

Both patches now applied.

Johan