linux-kernel - Re: [PATCH v2] arm64: dts: mt8192: Follow binding order for SCP registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 15:40:03 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, kernel@...labora.com,
        Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] arm64: dts: mt8192: Follow binding order for SCP
 registers



On 04/05/2022 23:45, Nícolas F. R. A. Prado wrote:
> The dt-binding for SCP documents the reg-names order as sram, cfg,
> l1tcm. Update the SCP node on the mt8192 devicetree to follow that
> order, which gets rid of a dtbs_check warning. This doesn't change any
> behavior since the SCP driver accesses the memory regions through the
> names anyway.
> 
> Fixes: c63556ec6bfe ("arm64: dts: mt8192: Add SCP node")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 

Applied thanks!

> ---
> 
> Changes in v2:
> - Added missing Fixes tag
> 
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 26dbe9ecc528..733aec2e7f77 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -699,9 +699,9 @@ spi7: spi@...1e000 {
>   		scp: scp@...00000 {
>   			compatible = "mediatek,mt8192-scp";
>   			reg = <0 0x10500000 0 0x100000>,
> -			      <0 0x10700000 0 0x8000>,
> -			      <0 0x10720000 0 0xe0000>;
> -			reg-names = "sram", "l1tcm", "cfg";
> +			      <0 0x10720000 0 0xe0000>,
> +			      <0 0x10700000 0 0x8000>;
> +			reg-names = "sram", "cfg", "l1tcm";
>   			interrupts = <GIC_SPI 435 IRQ_TYPE_LEVEL_HIGH 0>;
>   			clocks = <&infracfg CLK_INFRA_SCPSYS>;
>   			clock-names = "main";