linux-kernel - Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet speeds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47bafeae-34fb-fc55-3758-d248bd9706af@gmail.com>
Date:   Thu, 5 May 2022 15:46:03 +0200
From:   Rafał Miłecki <zajec5@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pavel Machek <pavel@....cz>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Hauke Mehrtens <hauke@...ke-m.de>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-leds@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Jonathan Corbet <corbet@....net>,
        John Crispin <john@...ozen.org>, linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: net: add bitfield defines for Ethernet
 speeds

I don't understand anything from below, I'm sorry. Could you clarify,
please?

On 5.05.2022 14:17, Andrew Lunn wrote:
> On Thu, May 05, 2022 at 07:19:41AM +0200, Rafał Miłecki wrote:
>> On 3.05.2022 17:36, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@...ecki.pl>
>>>
>>> This allows specifying multiple Ethernet speeds in a single DT uint32
>>> value.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
>>
>> Ansuel please check if my patchset conflicts in any way with your work.
>>
>> Andrew suggested to combine both but right now I don't see it as
>> necessary.
>>
>> I'd still appreciate your review of my work. Such binding may be
>> required for some hardware controlled LEDs setup too I guess.


 > Please look at the LED binding.

My binding or Ansuel's binding?


 > It is an LED you are trying to control, so that is the binding you should be using.

Well, of course, LED setup requires DT binding.


 > How do you describe this functionality using that binding.

I allow describing trigger source network device by using
"trigger-sources" property referencing network device. That is an
extension or what we already use for describing USB port that are
trigger sources.


 > Ansuel code will give you the framework to actually do the implementation within.

I was planning to base my work on top of Ansuel's one. I'll send proof
on concept meanwhile without asking for it to be applied.