linux-kernel - Re: CIFS regression mounting vers=1.0 NTLMSSP when hostname is too long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5muEMNZ8opMrkR4O5Od3W7oYmSgi9-ytQJqegF=XVJ757w@mail.gmail.com>
Date:   Thu, 5 May 2022 21:03:40 -0500
From:   Steve French <smfrench@...il.com>
To:     Paulo Alcantara <pc@....nz>
Cc:     Tom Talpey <tom@...pey.com>, Byron Stanoszek <gandalf@...ds.org>,
        Shyam Prasad N <nspmangalore@...il.com>,
        CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: CIFS regression mounting vers=1.0 NTLMSSP when hostname is too long

Yes - this makes sense.  Patch would be appreciated (just got back
from LSF/MM, so catching up after travel)

On Thu, May 5, 2022 at 8:59 PM Paulo Alcantara <pc@....nz> wrote:
>
> Tom Talpey <tom@...pey.com> writes:
>
> > I think the most conservative and spec-compliant choice should be made.
> > SMB1 should not be pushing the envelope of interoperability, in this day
> > and age.
>
> OK.
>
> > I believe the NetBIOS name is a fixed array of 16 octets, right? So, if
> > the nodename is shorter, it needs to be padded with 0's.
>
> Right.
>
> > Did this code change recently? Why???
>
> We used to not send the WorkstationName during NTLMSSP until recent
> patch from Shyam:
>
>         commit 49bd49f983b5026e4557d31c5d737d9657c4113e
>         Author: Shyam Prasad N <sprasad@...rosoft.com>
>         Date:   Fri Nov 5 19:03:57 2021 +0000
>
>             cifs: send workstation name during ntlmssp session setup
>
>             During the ntlmssp session setup (authenticate phases)
>             send the client workstation info. This can make debugging easier on
>             servers.
>
>             Signed-off-by: Shyam Prasad N <sprasad@...rosoft.com>
>             Reviewed-by: Paulo Alcantara (SUSE) <pc@....nz>
>             Reviewed-by: Enzo Matsumiya <ematsumiya@...e.de>
>             Signed-off-by: Steve French <stfrench@...rosoft.com>
>
> Unfortunately some servers did not seem to enforce it to be 16 bytes
> long, so the reason why we didn't catch it earlier.
>
> Steve, Shyam, let me know if it does make sense to you and then I can
> work on a patch to fix it properly.



-- 
Thanks,

Steve