linux-kernel - Re: [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506092152.405ce691@kernel.org>
Date:   Fri, 6 May 2022 09:21:52 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rolf Eike Beer <eike-kernel@...tec.de>
Cc:     linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
        netdev@...r.kernel.org, Yang Yingliang <yangyingliang@...wei.com>,
        davem@...emloft.net, edumazet@...gle.com
Subject: Re: [PATCH] ethernet: tulip: fix missing pci_disable_device() on
 error in tulip_init_one()

On Fri, 06 May 2022 12:11:56 +0200 Rolf Eike Beer wrote:
> Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang:
> > Fix the missing pci_disable_device() before return
> > from tulip_init_one() in the error handling case.  
> 
> I would suggest removing the pci_disable_device() from tulip_remove_one() 
> instead and using pcim_enable_device(), i.e. devres, and let the driver core 
> handle all these things. Of course more of the used functions could be 
> converted them, e.g. using devm_alloc_etherdev() and so on.

Let's not rewrite the error handling in this dinosaur of a driver 
any more than absolutely necessary, please.