linux-kernel - Re: ld.lld: error: inline assembly requires more registers than available at line 523

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnVRiiTeDjmcuo4o@dev-arch.thelio-3990X>
Date:   Fri, 6 May 2022 09:49:14 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Leonardo Bras Soares Passos <leobras@...hat.com>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: ld.lld: error: inline assembly requires more registers than
 available at line 523

On Wed, May 04, 2022 at 03:32:37PM -0700, Nathan Chancellor wrote:
> Hi Leo,
> 
> On Wed, May 04, 2022 at 03:13:56PM -0300, Leonardo Bras Soares Passos wrote:
> > On Wed, May 4, 2022 at 2:55 PM Nathan Chancellor <nathan@...nel.org> wrote:
> > >
> > > On Mon, May 02, 2022 at 06:29:38AM +0800, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > > head:   672c0c5173427e6b3e2a9bbb7be51ceeec78093a
> > > > commit: ba1f77c546966c12d86220d078e5838dcaeab348 x86/kvm: Fix compilation warning in non-x86_64 builds
> > > > date:   2 months ago
> > > > config: i386-randconfig-a012-20220502 (https://download.01.org/0day-ci/archive/20220502/202205020637.JVJo3blw-lkp@intel.com/config)
> > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 09325d36061e42b495d1f4c7e933e260eac260ed)
> > > > reproduce (this is a W=1 build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ba1f77c546966c12d86220d078e5838dcaeab348
> > > >         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > >         git fetch --no-tags linus master
> > > >         git checkout ba1f77c546966c12d86220d078e5838dcaeab348
> > > >         # save the config file
> > > >         mkdir build_dir && cp config build_dir/.config
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > >> ld.lld: error: inline assembly requires more registers than available at line 523
> > > > >> ld.lld: error: inline assembly requires more registers than available at line 523
> > > >
> > >
> > > I don't think this bisection result is correct; this error is visible at
> > > v5.17-rc3, which this commit is based on. This is likely the same root
> > > cause as https://github.com/ClangBuiltLinux/linux/issues/1589, just with
> > > LTO. I'll reduce something down and comment there if it turns out to be
> > > different.
> > >
> > > Cheers,
> > > Nathan
> > >
> > 
> > Hello Nathan,
> > I went down on this issue, but I have no idea how to proceed. These
> > are my findings:
> > - This commit (ba1f77c546966c12d86220d078e5838dcaeab348) fixes the
> > build, thus allowing this error to happen later (in LTO stage)
> > - The commit that introduced this issue was 69d0db01e210, due to removing :
> >    ubsan-cflags-$(CONFIG_UBSAN_OBJECT_SIZE)       += -fsanitize=object-size
> > - Only by having this flag enabled in ubsan-cflags-y on
> > torvalds/master causes the build to succeed
> 
> Ah, thanks for that investigation!
> 
> > At this point, given the commit message in 69d0db01e210 I was thinking
> > of finding & fixing the code that causes the ld.lld error to happen,
> > but I was lacking the skills to extract any filename from LTO step.
> 
> Right, this is not always easy with full LTO :( unfortunately, this
> issue is not reproducible with either no LTO or ThinLTO... When issues
> like this have come up in the past, I have had success linking
> individual object files/archives but that has not worked for this issue.
> I am going to try and bisect this randconfig against a defconfig and see
> if there is a minimal set of configs that reproduces this issue, which
> might make it easier to see what is going on here.
> 
> > But it's also possible to create a patch just adding
> > 'ubsan-cflags-$(CONFIG_SOMETHING)      += -fsanitize=object-size'
> > and fix this build.
> 
> Right, although that is basically reverting 69d0db01e210 for just that
> configuration, which we don't want to do for the reasons outlined in
> that commit message.
> 
> I'll see what comes of this config bisect.

i386_defconfig + CONFIG_LTO_CLANG_FULL=y + CONFIG_X86_GENERIC=y is
enough to reproduce this:

$ make -skj"$(nproc)" ARCH=i386 LLVM=1 mrproper defconfig

$ scripts/config -d LTO_NONE -e LTO_CLANG_FULL -e X86_GENERIC

$ make -skj"$(nproc)" ARCH=i386 LLVM=1 olddefconfig all
ld.lld: error: inline assembly requires more registers than available at line 538
ld.lld: error: inline assembly requires more registers than available at line 538

We have a known issue with 32-bit x86 '-march='/'-mtune=' and running
out of registers can be reproduced without LTO:

https://github.com/ClangBuiltLinux/linux/issues/1589

Until there is a fix for that, I don't think that it is worth
investigating this further.

Cheers,
Nathan