linux-kernel - Re: [PATCH] rfkill: uapi: fix RFKILL_IOCTL_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c66b3c0ba5d6076b00718f6df53f37ec8b099a04.camel@sipsolutions.net>
Date:   Fri, 06 May 2022 19:21:11 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>,
        Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rfkill: uapi: fix RFKILL_IOCTL_MAX_SIZE ioctl request
 definition

On Fri, 2022-05-06 at 17:15 +0000, Gleb Fotengauer-Malinovskiy wrote:
> Fixes: 54f586a91532 ("rfkill: make new event layout opt-in")
> ---
>  include/uapi/linux/rfkill.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/rfkill.h b/include/uapi/linux/rfkill.h
> index 283c5a7b3f2c..db6c8588c1d0 100644
> --- a/include/uapi/linux/rfkill.h
> +++ b/include/uapi/linux/rfkill.h
> @@ -184,7 +184,7 @@ struct rfkill_event_ext {
>  #define RFKILL_IOC_NOINPUT	1
>  #define RFKILL_IOCTL_NOINPUT	_IO(RFKILL_IOC_MAGIC, RFKILL_IOC_NOINPUT)
>  #define RFKILL_IOC_MAX_SIZE	2
> -#define RFKILL_IOCTL_MAX_SIZE	_IOW(RFKILL_IOC_MAGIC, RFKILL_IOC_EXT_SIZE, __u32)
> +#define RFKILL_IOCTL_MAX_SIZE	_IOW(RFKILL_IOC_MAGIC, RFKILL_IOC_MAX_SIZE, __u32)
> 

Oops. But I still need your Signed-off-by (see the documentation), and a
commit message would be nice :)

johannes