linux-kernel - Re: [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 May 2022 20:36:51 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ilkka Koskinen <ilkka@...amperecomputing.com>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Hanjun Guo <guohanjun@...wei.com>,
        Sudeep Holla <sudeep.holla@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: AGDI: Fix missing prototype warning for acpi_agdi_init()

On Tue, Apr 26, 2022 at 12:18 AM Ilkka Koskinen
<ilkka@...amperecomputing.com> wrote:
>
> When building with W=1, we get the following warning:
>
> drivers/acpi/arm64/agdi.c:88:13: warning: no previous prototype for ‘acpi_agdi_init’ [-Wmissing-prototypes]
>  void __init acpi_agdi_init(void)
>
> Include AGDI driver's header file to pull in the prototype definition
> for acpi_agdi_init() to get rid of the compiler warning
>
> Fixes: a2a591fb76e6 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> ---
>  drivers/acpi/arm64/agdi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c
> index 4df337d545b7..cf31abd0ed1b 100644
> --- a/drivers/acpi/arm64/agdi.c
> +++ b/drivers/acpi/arm64/agdi.c
> @@ -9,6 +9,7 @@
>  #define pr_fmt(fmt) "ACPI: AGDI: " fmt
>
>  #include <linux/acpi.h>
> +#include <linux/acpi_agdi.h>
>  #include <linux/arm_sdei.h>
>  #include <linux/io.h>
>  #include <linux/kernel.h>
> --

Applied as 5.19 material, thanks!