lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 6 May 2022 16:48:49 -0400
From:   Ian Cowan <ian@...ux.cowan.aero>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: acpi: clean up spaces to be consistent

On Fri, May 06, 2022 at 08:34:09PM +0200, Rafael J. Wysocki wrote:
> On Mon, Apr 25, 2022 at 4:14 AM Ian Cowan <ian@...ux.cowan.aero> wrote:
> > @@ -190,12 +190,14 @@ static int acpi_ac_battery_notify(struct notifier_block *nb,
> >  static int __init thinkpad_e530_quirk(const struct dmi_system_id *d)
> >  {
> >         ac_sleep_before_get_state_ms = 1000;
> > +
> >         return 0;
> >  }
> >
> >  static int __init ac_only_quirk(const struct dmi_system_id *d)
> >  {
> >         ac_only = 1;
> > +
> >         return 0;
> >  }
> 
> I don't really think that it is useful to add empty lines in the two
> cases above.
> 
> The rest of the patch is fine with me.
> 

I just submitted v2 removing these 2 changes and leaving the others.

Thanks!
Ian

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ