linux-kernel - Re: [PATCH v2 4/4] staging: media: zoran: replace dprintk with new debugging macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnWJ9M19t57yqRz/@fedora>
Date:   Fri, 6 May 2022 16:49:56 -0400
From:   Ian Cowan <ian@...ux.cowan.aero>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Hans Verkuil <hverkuil@...all.nl>,
        Corentin Labbe <clabbe@...libre.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        mjpeg-users@...ts.sourceforge.net, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] staging: media: zoran: replace dprintk with new
 debugging macros

On Fri, May 06, 2022 at 10:14:55AM +0300, Dan Carpenter wrote:
> On Fri, May 06, 2022 at 01:30:12AM -0400, Ian Cowan wrote:
> > On Thu, Apr 28, 2022 at 10:15:03AM +0200, Hans Verkuil wrote:
> > > Hi Ian,
> > > 
> > > When I compiled this patch series with smatch I got these warnings:
> > > 
> > > zoran/videocodec.c:45 videocodec_attach() warn: variable dereferenced before check 'master' (see line 40)
> > > zoran/videocodec.c:115 videocodec_detach() warn: variable dereferenced before check 'codec' (see line 111)
> > > zoran/videocodec.c:168 videocodec_register() warn: variable dereferenced before check 'codec' (see line 166)
> > > zoran/videocodec.c:200 videocodec_unregister() warn: variable dereferenced before check 'codec' (see line 198)
> > > 
> > > And I also got this warning when checking the kerneldoc:
> > > 
> > > zoran/zoran.h:307: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> > >
> > What did you use to see these issues? When I ran the checkpatch script
> > and compiled, I did not see any of this.
> > 
> 
> I have written a blog entry about checking kernel code with Smatch:
> 
> https://staticthinking.wordpress.com/2022/04/25/how-to-run-smatch-on-your-code/
> 
> regards,
> dan carpenter
> 

Fantastic, I'll give that a read.

Thanks!
Ian