linux-kernel - Re: [PATCH V1 15/23] perf intel-pt: Use evlist__add_system_wide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUmXU7smPbGvK8Q1RxfZ-7C+WbUK_Xa9yz3WgQdk9YdPw@mail.gmail.com>
Date:   Thu, 5 May 2022 16:58:02 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexey Bayduraev <alexey.v.bayduraev@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Leo Yan <leo.yan@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 15/23] perf intel-pt: Use evlist__add_system_wide_dummy()
 for switch tracking

On Thu, May 5, 2022 at 9:57 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> Use evlist__add_system_wide_dummy() for switch tracking in preparation for
> allowing system-wide events on all CPUs while the user requested events are
> on only user requested CPUs.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Delta function names.

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/arch/x86/util/intel-pt.c | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/tools/perf/arch/x86/util/intel-pt.c b/tools/perf/arch/x86/util/intel-pt.c
> index 2eaac4638aab..e45d64dec57c 100644
> --- a/tools/perf/arch/x86/util/intel-pt.c
> +++ b/tools/perf/arch/x86/util/intel-pt.c
> @@ -811,18 +811,11 @@ static int intel_pt_recording_options(struct auxtrace_record *itr,
>                         if (!cpu_wide && perf_can_record_cpu_wide()) {
>                                 struct evsel *switch_evsel;
>
> -                               err = parse_events(evlist, "dummy:u", NULL);
> -                               if (err)
> -                                       return err;
> +                               switch_evsel = evlist__add_system_wide_dummy(evlist);
> +                               if (!switch_evsel)
> +                                       return -ENOMEM;
>
> -                               switch_evsel = evlist__last(evlist);
> -
> -                               switch_evsel->core.attr.freq = 0;
> -                               switch_evsel->core.attr.sample_period = 1;
>                                 switch_evsel->core.attr.context_switch = 1;
> -
> -                               switch_evsel->core.system_wide = true;
> -                               switch_evsel->no_aux_samples = true;
>                                 switch_evsel->immediate = true;
>
>                                 evsel__set_sample_bit(switch_evsel, TID);
> --
> 2.25.1
>