| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 May 2022 11:57:18 +0800
From: kernel test robot <lkp@...el.com>
To: Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org, 0day robot <lkp@...el.com>
Subject: fs/f2fs/inode.c:284:26: warning: format specifies type 'long' but
the argument has type 'unsigned int'
tree: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20220505-223550/Chao-Yu/f2fs-fix-to-do-sanity-check-for-inline-inode/20220428-105005
head: 632856cc52a2023c9f07eea39ea41ddff5389997
commit: 632856cc52a2023c9f07eea39ea41ddff5389997 f2fs: fix to do sanity check for inline inode
date: 13 hours ago
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220506/202205061127.vt9N0sP5-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/632856cc52a2023c9f07eea39ea41ddff5389997
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review UPDATE-20220505-223550/Chao-Yu/f2fs-fix-to-do-sanity-check-for-inline-inode/20220428-105005
git checkout 632856cc52a2023c9f07eea39ea41ddff5389997
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/net/wireless/ath/ath6kl/ drivers/net/wireless/broadcom/brcm80211/brcmfmac/ drivers/net/wireless/marvell/libertas/ drivers/net/wireless/marvell/mwifiex/ drivers/net/wireless/microchip/wilc1000/ drivers/staging/rtl8723bs/ fs/f2fs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> fs/f2fs/inode.c:284:26: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
i_size_read(inode), MAX_INLINE_DATA(inode),
^~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/f2fs.h:2353:39: note: expanded from macro 'f2fs_warn'
f2fs_printk(sbi, KERN_WARNING fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
fs/f2fs/f2fs.h:463:32: note: expanded from macro 'MAX_INLINE_DATA'
#define MAX_INLINE_DATA(inode) (sizeof(__le32) * \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +284 fs/f2fs/inode.c
202
203 static bool sanity_check_inode(struct inode *inode, struct page *node_page)
204 {
205 struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
206 struct f2fs_inode_info *fi = F2FS_I(inode);
207 struct f2fs_inode *ri = F2FS_INODE(node_page);
208 unsigned long long iblocks;
209
210 iblocks = le64_to_cpu(F2FS_INODE(node_page)->i_blocks);
211 if (!iblocks) {
212 set_sbi_flag(sbi, SBI_NEED_FSCK);
213 f2fs_warn(sbi, "%s: corrupted inode i_blocks i_ino=%lx iblocks=%llu, run fsck to fix.",
214 __func__, inode->i_ino, iblocks);
215 return false;
216 }
217
218 if (ino_of_node(node_page) != nid_of_node(node_page)) {
219 set_sbi_flag(sbi, SBI_NEED_FSCK);
220 f2fs_warn(sbi, "%s: corrupted inode footer i_ino=%lx, ino,nid: [%u, %u] run fsck to fix.",
221 __func__, inode->i_ino,
222 ino_of_node(node_page), nid_of_node(node_page));
223 return false;
224 }
225
226 if (f2fs_sb_has_flexible_inline_xattr(sbi)
227 && !f2fs_has_extra_attr(inode)) {
228 set_sbi_flag(sbi, SBI_NEED_FSCK);
229 f2fs_warn(sbi, "%s: corrupted inode ino=%lx, run fsck to fix.",
230 __func__, inode->i_ino);
231 return false;
232 }
233
234 if (f2fs_has_extra_attr(inode) &&
235 !f2fs_sb_has_extra_attr(sbi)) {
236 set_sbi_flag(sbi, SBI_NEED_FSCK);
237 f2fs_warn(sbi, "%s: inode (ino=%lx) is with extra_attr, but extra_attr feature is off",
238 __func__, inode->i_ino);
239 return false;
240 }
241
242 if (fi->i_extra_isize > F2FS_TOTAL_EXTRA_ATTR_SIZE ||
243 fi->i_extra_isize % sizeof(__le32)) {
244 set_sbi_flag(sbi, SBI_NEED_FSCK);
245 f2fs_warn(sbi, "%s: inode (ino=%lx) has corrupted i_extra_isize: %d, max: %zu",
246 __func__, inode->i_ino, fi->i_extra_isize,
247 F2FS_TOTAL_EXTRA_ATTR_SIZE);
248 return false;
249 }
250
251 if (f2fs_has_extra_attr(inode) &&
252 f2fs_sb_has_flexible_inline_xattr(sbi) &&
253 f2fs_has_inline_xattr(inode) &&
254 (!fi->i_inline_xattr_size ||
255 fi->i_inline_xattr_size > MAX_INLINE_XATTR_SIZE)) {
256 set_sbi_flag(sbi, SBI_NEED_FSCK);
257 f2fs_warn(sbi, "%s: inode (ino=%lx) has corrupted i_inline_xattr_size: %d, max: %zu",
258 __func__, inode->i_ino, fi->i_inline_xattr_size,
259 MAX_INLINE_XATTR_SIZE);
260 return false;
261 }
262
263 if (F2FS_I(inode)->extent_tree) {
264 struct extent_info *ei = &F2FS_I(inode)->extent_tree->largest;
265
266 if (ei->len &&
267 (!f2fs_is_valid_blkaddr(sbi, ei->blk,
268 DATA_GENERIC_ENHANCE) ||
269 !f2fs_is_valid_blkaddr(sbi, ei->blk + ei->len - 1,
270 DATA_GENERIC_ENHANCE))) {
271 set_sbi_flag(sbi, SBI_NEED_FSCK);
272 f2fs_warn(sbi, "%s: inode (ino=%lx) extent info [%u, %u, %u] is incorrect, run fsck to fix",
273 __func__, inode->i_ino,
274 ei->blk, ei->fofs, ei->len);
275 return false;
276 }
277 }
278
279 if (f2fs_has_inline_data(inode) && !f2fs_may_inline_data(inode)) {
280 set_sbi_flag(sbi, SBI_NEED_FSCK);
281 f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) reason(%d, %llu, %ld, %d, %d, %lu) should not have inline_data, run fsck to fix",
282 __func__, inode->i_ino, inode->i_mode,
283 f2fs_is_atomic_file(inode),
> 284 i_size_read(inode), MAX_INLINE_DATA(inode),
285 file_is_encrypt(inode), file_is_verity(inode),
286 F2FS_I(inode)->i_flags & F2FS_COMPR_FL);
287 return false;
288 }
289
290 if (f2fs_has_inline_dentry(inode) && !S_ISDIR(inode->i_mode)) {
291 set_sbi_flag(sbi, SBI_NEED_FSCK);
292 f2fs_warn(sbi, "%s: inode (ino=%lx, mode=%u) should not have inline_dentry, run fsck to fix",
293 __func__, inode->i_ino, inode->i_mode);
294 return false;
295 }
296
297 if ((fi->i_flags & F2FS_CASEFOLD_FL) && !f2fs_sb_has_casefold(sbi)) {
298 set_sbi_flag(sbi, SBI_NEED_FSCK);
299 f2fs_warn(sbi, "%s: inode (ino=%lx) has casefold flag, but casefold feature is off",
300 __func__, inode->i_ino);
301 return false;
302 }
303
304 if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) &&
305 fi->i_flags & F2FS_COMPR_FL &&
306 F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
307 i_log_cluster_size)) {
308 if (ri->i_compress_algorithm >= COMPRESS_MAX) {
309 set_sbi_flag(sbi, SBI_NEED_FSCK);
310 f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
311 "compress algorithm: %u, run fsck to fix",
312 __func__, inode->i_ino,
313 ri->i_compress_algorithm);
314 return false;
315 }
316 if (le64_to_cpu(ri->i_compr_blocks) >
317 SECTOR_TO_BLOCK(inode->i_blocks)) {
318 set_sbi_flag(sbi, SBI_NEED_FSCK);
319 f2fs_warn(sbi, "%s: inode (ino=%lx) has inconsistent "
320 "i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",
321 __func__, inode->i_ino,
322 le64_to_cpu(ri->i_compr_blocks),
323 SECTOR_TO_BLOCK(inode->i_blocks));
324 return false;
325 }
326 if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||
327 ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {
328 set_sbi_flag(sbi, SBI_NEED_FSCK);
329 f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
330 "log cluster size: %u, run fsck to fix",
331 __func__, inode->i_ino,
332 ri->i_log_cluster_size);
333 return false;
334 }
335 }
336
337 return true;
338 }
339
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists