linux-kernel - Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72n+g_=QQcSuE13+58j+PCuqLEyCusEUqMKFywR8UKHK6g@mail.gmail.com>
Date:   Fri, 6 May 2022 07:26:12 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Changbin Du <changbin.du@...el.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        rust-for-linux <rust-for-linux@...r.kernel.org>,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH v1 1/3] kallsyms: avoid hardcoding the buffer size

On Fri, May 6, 2022 at 1:46 AM Kees Cook <keescook@...omium.org> wrote:
>
> No need to repeat the sizing:
>
>         fgets(name, sizeof(name), in)

Definitely.

> Reviewed-by: Kees Cook <keescook@...omium.org>

Thanks for the three reviews!

Cheers,
Miguel