linux-kernel - RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SA2PR11MB51157FBE0367288DEBC4396BC3C59@SA2PR11MB5115.namprd11.prod.outlook.com>
Date:   Fri, 6 May 2022 05:28:36 +0000
From:   "R, Monish Kumar" <monish.kumar.r@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "olebowle@....com" <olebowle@....com>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "vpalatin@...omium.org" <vpalatin@...omium.org>,
        "wangjm221@...il.com" <wangjm221@...il.com>,
        "chris.chiu@...onical.com" <chris.chiu@...onical.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Rao, Abhijeet" <abhijeet.rao@...el.com>
Subject: RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for
 Dell usb gen 2 device to not fail during enumeration.

Hi greg,

Are you sure you need both?  How was this tested that both are actually set?

>>  Yes, both NO_LPM and RESET_RESUME quirks were needed.
As the Dell usb gen2 device U1/U2 link states were failing when connected to type-C ports.
Disabling LPM helps to resolve U1/U2 link state failures. However, it leads to resetting the device multiple times. So, added with NO_LPM and RESET_RESUME usb quirks.

Tested multiple hotplug of Dell usb gen 2 device, it passed for all the cases.

Regards,
Monish Kumar R

-----Original Message-----
From: Greg KH <gregkh@...uxfoundation.org> 
Sent: 05 May 2022 17:47
To: R, Monish Kumar <monish.kumar.r@...el.com>
Cc: olebowle@....com; oneukum@...e.com; vpalatin@...omium.org; wangjm221@...il.com; chris.chiu@...onical.com; linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Rao, Abhijeet <abhijeet.rao@...el.com>
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for Dell usb gen 2 device to not fail during enumeration.

On Thu, May 05, 2022 at 03:44:59PM +0530, monish.kumar.r@...el.com wrote:
> From: Monish Kumar R <monish.kumar.r@...el.com>
> 
> Signed-off-by: Monish Kumar R <monish.kumar.r@...el.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c 
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id 
> usb_quirk_list[] = {
>  
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME 
> },
>         
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info = USB_QUIRK_RESET_RESUME 
> +},

Are you sure you need both?  How was this tested that both are actually set?

thanks,

greg k-h