linux-kernel - Re: [PATCH] lib/string_helpers: add allocated strarray to device's resource list.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 May 2022 08:43:24 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Puyou Lu <puyou.lu@...il.com>
Cc:     akpm@...ux-foundation.org, andy@...nel.org, chris@...isdown.name,
        keescook@...omium.org, linus.walleij@...aro.org,
        linux-kernel@...r.kernel.org, linux@...ck-us.net, pmladek@...e.com
Subject: Re: [PATCH] lib/string_helpers: add allocated strarray to device's
 resource list.

On Fri, May 6, 2022 at 6:44 AM Puyou Lu <puyou.lu@...il.com> wrote:
>
> This is a must to automatically release strarray when the device
> disappears.

Thanks for your patch!

First of all, since this is a v2 of it, you need to update the subject
to reflect this and add a changelog after the cutter '--- ' line
below.
Second, because this is the fix, please add a Fixes tag.

> Signed-off-by: Puyou Lu <puyou.lu@...il.com>
> ---
>  lib/string_helpers.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/string_helpers.c b/lib/string_helpers.c
> index 4f877e9551d5..5ed3beb066e6 100644
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -757,6 +757,9 @@ char **devm_kasprintf_strarray(struct device *dev, const char *prefix, size_t n)
>                 return ERR_PTR(-ENOMEM);
>         }
>
> +       ptr->n = n;
> +       devres_add(dev, ptr);

The code seems correct, good catch!

>         return ptr->array;
>  }
>  EXPORT_SYMBOL_GPL(devm_kasprintf_strarray);
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko