linux-kernel - Re: [PATCH] x86/Hyper-V: Add SEV negotiate protocol support in Isolation VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 May 2022 14:46:54 +0800
From:   Tianyu Lan <ltykernel@...il.com>
To:     Andrea Parri <parri.andrea@...il.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        x86@...nel.org, hpa@...or.com, brijesh.singh@....com,
        venu.busireddy@...cle.com, michael.roth@....com,
        Tianyu.Lan@...rosoft.com, thomas.lendacky@....com, jroedel@...e.de,
        michael.h.kelley@...rosoft.com, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, vkuznets@...hat.com
Subject: Re: [PATCH] x86/Hyper-V: Add SEV negotiate protocol support in
 Isolation VM

On 5/5/2022 11:47 PM, Andrea Parri wrote:
> On Thu, May 05, 2022 at 09:15:02AM -0400, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@...rosoft.com>
>>
>> Hyper-V Isolation VM code uses sev_es_ghcb_hv_call() to read/write MSR
>> via GHCB page. The SEV-ES guest should negotiate GHCB version before
>> reading/writing MSR via GHCB page. Expose sev_es_negotiate_protocol()
>> and sev_es_terminate() from AMD SEV code and negotiate GHCB version in
>> hyperv_init_ghcb() fro Hyper-V Isolation VM.
>>
>> Signed-off-by: Tianyu Lan <Tianyu.Lan@...rosoft.com>
> 
> Applied to tip's x86/sev and checked that this can fix the regression (to
> be introduced) by commit 2ea29c5abbc2 ("x86/sev: Save the negotiated GHCB
> version"):
> 
> Tested-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> 
> Nits: (in the commit message) fro -> for, Isolation VM -> Isolated VM
> 

Nice catch! Thanks.